Expand on the documentation for polymorphization. #803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit elaborates on the existing documentation for polymorphization now that polymorphization has almost landed in rustc. Signed-off-by: David Wood <david@davidtw.co>
spastorino
approved these changes
Jul 17, 2020
|
Let's wait for it to land and re-run the CI then. |
JohnTitor
approved these changes
Jul 22, 2020
There was a problem hiding this comment.
It's now green!
@davidtwco is there any update? If not, I'm going to merge this. Thanks for great work (I know you're working on today's regression, there is no rush :)).
We should be able to merge this now if CI is passing, I don't have any changes to make to the content. |
JohnTitor
pushed a commit
to shepmaster/rustc-dev-guide
that referenced
this pull request
Jul 28, 2020
This commit elaborates on the existing documentation for polymorphization now that polymorphization has almost landed in rustc. Signed-off-by: David Wood <david@davidtw.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR elaborates on the existing documentation for polymorphization now that polymorphization has almost landed in rustc (rust-lang/rust#69749).
Note: CI will fail as this links to rustc rustdoc entries which won't exist until polymorphization is merged.